Skip to content

Find all the solutions of NQueen #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2021
Merged

Find all the solutions of NQueen #619

merged 1 commit into from
Jun 7, 2021

Conversation

mhihasan
Copy link
Contributor

@mhihasan mhihasan commented Jun 6, 2021 •
edited
Loading

Welcome to JavaScript community

Open in Gitpod know more

Describing changes:

  • Find all solutions for NQueen problem
  • Add unittest for NQueen.js
  • Refactor some codes

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Fixes #620

@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2021

This pull request introduces 1 alert when merging 5d6ef93 into a9b1f89 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@mhihasan mhihasan force-pushed the update_nqeen_algo branch from c9950f7 to fb8768e Compare June 6, 2021 06:03
@mhihasan mhihasan force-pushed the update_nqeen_algo branch from fb8768e to e9fd4a9 Compare June 6, 2021 06:06
@raklaptudirm raklaptudirm merged commit c423e6e into TheAlgorithms:master Jun 7, 2021
@mhihasan mhihasan deleted the update_nqeen_algo branch June 7, 2021 05:17
@mhihasan mhihasan restored the update_nqeen_algo branch June 7, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find all solutions of NQueen problem
2 participants
@mhihasan @raklaptudirm